Add option to repeat the current video#37
Open
hymansun wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the contribution, @hymansun — but I don't think I can merge this one. Let me explain the reasoning so you can decide what to do with the branch. Macify is built around random playback as a core behavior, not as a default that users might want to override:
That's just one example of the conflict — and I want to be upfront that even if that specific case were resolved, I still wouldn't want to add a "repeat current video" option, because it cuts against the product's core idea. If this is something you personally want, I'd suggest keeping the change on your own fork. Really appreciate the effort you put in here, but I'll have to pass on merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repeatCurrentVideosetting, defaulting to off<video>when enabled while preserving the existing auto-next behavior when disabledTest
npm run build