Skip to content

update lib/devtools to set window size and position on initialization #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
starpit wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

update lib/devtools to set window size and position on initialization #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd91564
update lib/devtools to set window size and position on initialization
starpit Jun 19, 2017
f090e1e
fix for missing Promise.resolve() in the _resize update
starpit Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lib/devtools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,18 @@ const Devtools = module.exports = function (options) {
log.silly('devtools: create')

this.options = options || {}

// the caller make have asked us to set the window size and position
const chromeOptions = new chrome.Options()
if (this.options.width && this.options.height) {
chromeOptions.addArguments([`--window-size=${this.options.width},${this.options.height}`])
}
if (this.options.windowPosition) {
chromeOptions.addArguments([`--window-position=${this.options.windowPosition.left},${this.options.windowPosition.top}`])
}

this.service = new chrome.ServiceBuilder(chromedriver.path).build()
this.driver = chrome.Driver.createSession(new chrome.Options(), this.service)
this.driver = chrome.Driver.createSession(chromeOptions, this.service)
}

Devtools.prototype.open = function (debuggerUrl, options) {
Expand Down Expand Up @@ -68,6 +78,11 @@ Devtools.prototype._resize = function () {

const window = this.driver.manage().window()

// this may now be done on initialization, above
if (this.options.width && this.options.height) {
return Promise.resolve(window)
}

return window.getSize()
.then((size) => window.setSize(size.width, 450))
}
Expand Down