fix: correct scroll conflicts, viewport units, and CSS typo in cards.scss#8
Open
jaredgoldman wants to merge 1 commit intomainfrom
Open
fix: correct scroll conflicts, viewport units, and CSS typo in cards.scss#8jaredgoldman wants to merge 1 commit intomainfrom
jaredgoldman wants to merge 1 commit intomainfrom
Conversation
…scss - Fix ease-in-outo typo to ease-in-out in .project-title transition - Change min-height from 100vh to 100dvh so cards fit mobile viewports correctly - Remove redundant overflow-y: auto from .card, .bio-inner, and .card-content to eliminate scroll chaining; keep only on .card-content_left and .projects which are the actual scrollable content areas - Remove duplicate padding-right declaration in max-width: 600px media block Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for jared-goldman-portfolio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ease-in-outo→ease-in-outin.project-titletransition (line 194)min-height: 100vh→min-height: 100dvhon.cardandmax-height: 100vh→max-height: 100dvhin the 600px media block; also updatedheight: 100vh→height: 100dvhon.projects-innerin the same block — aligns with the rest of the app and prevents cards from exceeding the visible area on mobileoverflow-y: autofrom.card,.bio-inner, and.card-content(including all media query overrides) — these nested containers don't need scroll themselves; only.card-content_leftand.projects(the actual text content areas) retainoverflow-y: autopadding-right: 0declaration in the 600px block that was immediately overriddenTest plan
pnpm run css— no SCSS errors (only pre-existing deprecation warnings)card-content_left) still scrolls independently🤖 Generated with Claude Code