fix: rewrite pill indicator to track horizontal card scroll#7
Open
jaredgoldman wants to merge 1 commit intomainfrom
Open
fix: rewrite pill indicator to track horizontal card scroll#7jaredgoldman wants to merge 1 commit intomainfrom
jaredgoldman wants to merge 1 commit intomainfrom
Conversation
Pill indicator was listening to window.scroll and reading window.scrollY, both permanently 0 because html/body is position:fixed. Now listens to #container scroll events and tracks scrollLeft percentage so the dot correctly reflects which card the user is on. Also skips redundant forced reflow when indicator is already visible. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for jared-goldman-portfolio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.scroll/window.scrollY, both always 0 becausehtml,bodyisposition:fixed#containerscroll events and computescrollLeft / (scrollWidth - clientWidth)percentageTest plan
🤖 Generated with Claude Code