fix: make modal position fixed and scrollable at all breakpoints#6
Open
jaredgoldman wants to merge 1 commit intomainfrom
Open
fix: make modal position fixed and scrollable at all breakpoints#6jaredgoldman wants to merge 1 commit intomainfrom
jaredgoldman wants to merge 1 commit intomainfrom
Conversation
- Change position from absolute to fixed so the modal correctly overlays the viewport when html/body are position:fixed - Add max-height: 100dvh and overflow-y: auto at the base level so content scrolls at desktop/tablet sizes, not only on mobile - Add overscroll-behavior: contain to prevent scroll events from bubbling out to the card navigation - Remove now-redundant overflow-y: auto from the mobile media query Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for jared-goldman-portfolio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.modalpositionfromabsolutetofixedso it correctly overlays the viewport whenhtml/bodyareposition: fixedmax-height: 100dvhandoverflow-y: autoat the base.modallevel so content scrolls on desktop/tablet as well as mobileoverscroll-behavior: containto prevent scroll events from bubbling out to the card navigation when the modal is scrolledoverflow-y: autofrom the@media (max-width: 600px)blockTest plan
🤖 Generated with Claude Code