fix: prevent permanent isScrolling lock when tab is backgrounded#4
Open
jaredgoldman wants to merge 1 commit intomainfrom
Open
fix: prevent permanent isScrolling lock when tab is backgrounded#4jaredgoldman wants to merge 1 commit intomainfrom
jaredgoldman wants to merge 1 commit intomainfrom
Conversation
Add a safety setTimeout that forces isScrolling = false after duration + 100ms, so navigation is never permanently blocked if requestAnimationFrame callbacks are suspended (e.g. tab switch). The timeout is cleared on the normal animation-complete path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for jared-goldman-portfolio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smoothScrollTosetsisScrolling = trueat the start and only resets it inside arequestAnimationFramecallback, which is suspended when the user switches tabs — permanently locking navigation.setTimeoutsafety fallback that forcesisScrolling = falseafterduration + 100ms.clearTimeoutcancels the safety timer so there is no double-reset or race.Test plan
node --check scripts/navigation.jspasses (no syntax errors)🤖 Generated with Claude Code