fix: add missing scroll-indicator element and null guard#10
Open
jaredgoldman wants to merge 1 commit intomainfrom
Open
fix: add missing scroll-indicator element and null guard#10jaredgoldman wants to merge 1 commit intomainfrom
jaredgoldman wants to merge 1 commit intomainfrom
Conversation
Add <div id="scroll-indicator"> to index.html so the element exists in the DOM, and add a null guard in loadScrollIndicator() to prevent a silent crash when the element is absent. Also remove redundant load event listener and unnecessary narrating comments. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for jared-goldman-portfolio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<div id="scroll-indicator" class="scroll-indicator"></div>inside#containerinindex.htmlso the element exists in the DOM (it was missing, causing a null reference crash)if (!scrollIndicator) return;) at the top ofloadScrollIndicator()as a defensive fallbackwindow.addEventListener('load', ...)call that would re-triggershowAndFadeIndicator1.5s after page load, interrupting the first animation cycleTest plan
pnpm run csscompiles with no errorsnode --check scripts/scrollIndicator.jspasses with no syntax errors🤖 Generated with Claude Code