Repository navigation
feat(skills): add pr skill for pull request bodies - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Containers open pull requests, but no skill said what goes into the body, so bodies filled up with gate counts, baseline comparisons and
file://links a reviewer cannot open. This adds a container skill,pr, adapted from Matt Pocock'sprskill, and points the container rules at it for the first body and every later rewrite.skills/container/ ├── babysit-pr/SKILL.md # a body that changes is rewritten the way it was opened +└── pr/SKILL.md # Summary, Evidence, Merge danger sbx/container/sandbox.md # the pull request body follows skill `pr` src/render/render.test.ts # `/pr/SKILL.md` pinned to the container seat THIRD_PARTY_NOTICES.md # credit beside the existing mattpocock entryThe skill keeps the source's three sections and adds what this setup needs: the tracker issue as a link on the first line, evidence a reviewer can check from the diff, repository-relative paths only, and one line under merge danger for each thing the change does not fix, each open review finding and each CI check that also fails on the base.
babysit-prcannot name another skill (src/render/layers.tsfails the build on it), sosandbox.mdnamesprandbabysit-prkeeps thegh api -X PATCHcommand.Evidence
skills/container/pr/removed,the <kind> reviewer, conflict procedure and pull request body reach only the containerfails for pi and claude oncontainer lacks /pr/SKILL.md.After: with the skill in place it passes. The pin uses
/pr/SKILL.mdbecausepr/SKILL.mdalso matchesbabysit-pr/SKILL.md.fleet render --seat containerfor pi and for claude both writeskills/pr/SKILL.md, and the rendered sandbox rule names skillpr.Merge danger
Door: two-way. The change is Markdown plus one test line; a revert removes the skill from the next rendered image.
Blast radius: containers. Every container seat reads the changed
sandbox.mdandbabysit-pr, so a wrong instruction shapes every pull request body they write.show-mesource is credited by name; its licence terms were not checked.