Fix json_parse to return Map instead of Record for JSON objects#30
Merged
Conversation
JSON objects parsed via json_parse() were returned as Value::Record, which meant map methods like .get(), .keys(), .values(), .entries() etc. were unavailable on parsed objects. Changed json_parse_object to build Vec<(Value, Value)> and return Value::Map so that all Map instance methods work on parsed JSON objects. Also added Value::Map support to Expr::FieldAccess so that dot-syntax (e.g. obj.name) continues to work on Map values, preserving backward compatibility with existing code. https://claude.ai/code/session_01XWitYKfWuyRZshH5rjuQF6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON objects parsed via json_parse() were returned as Value::Record,
which meant map methods like .get(), .keys(), .values(), .entries()
etc. were unavailable on parsed objects. Changed json_parse_object to
build Vec<(Value, Value)> and return Value::Map so that all Map
instance methods work on parsed JSON objects.
Also added Value::Map support to Expr::FieldAccess so that dot-syntax
(e.g. obj.name) continues to work on Map values, preserving backward
compatibility with existing code.
https://claude.ai/code/session_01XWitYKfWuyRZshH5rjuQF6