feat: add S3 auth support (behind a new feature flag)#172
Open
mat813 wants to merge 1 commit intojaemk:masterfrom
Open
feat: add S3 auth support (behind a new feature flag)#172mat813 wants to merge 1 commit intojaemk:masterfrom
mat813 wants to merge 1 commit intojaemk:masterfrom
Conversation
mat813
force-pushed
the
s3-auth
branch
2 times, most recently
from
0000341 to
0000341
Compare
Collaborator
|
Have you tested this? |
GideonBear
approved these changes
Apr 4, 2026
Collaborator
GideonBear
left a comment
GideonBear
left a comment
There was a problem hiding this comment.
Few nits, assuming you've tested everything, and have done your research on how to implement AWS sign v4 :)
Contributor
Author
And yes, I have tested this, it works with our minio and seaweedfs object storage. I don't have an actual s3 bucket to test things with, but I don't see why it would fail there. |
mat813
force-pushed
the
s3-auth
branch
2 times, most recently
from
0000348 to
0000348
Compare
Contributor
Author
|
I removed a few string cloning, and a TODO item I had. |
GideonBear
reviewed
Apr 7, 2026
| #[cfg(feature = "s3-auth")] | ||
| access_key_id: Option<String>, | ||
| #[cfg(feature = "s3-auth")] | ||
| secret_access_key: Option<String>, |
Collaborator
There was a problem hiding this comment.
If these always both need to be supplied, does it make more sense to have a single Option<(String, String)>? Or does that obscure the meaning too much in your opinion?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88