test: Add comprehensive tests for log_scan_summary function

[Copilot]

Issue #34 requested comprehensive tests for mother::commands::scan::log_scan_summary. This function formats scan completion logs based on phase results and error counts.

Changes

• Created tests_log_scan_summary.rs: 33 tests covering the function through its public API

  • Zero count scenarios (all zeros, individual zero counts)
  • Error distribution patterns (single phase, multiple phases, all phases)
  • Large value handling (thousands to max usize safe values)
  • Realistic scenarios (small/medium/large projects, incremental vs first scan)
  • Edge cases (unbalanced ratios, high error rates)

• Updated mod.rs: Added test module declaration

The function has two output paths based on error count:

fn log_scan_summary(phase1: &Phase1Result, phase2: &Phase2Result, phase3: &Phase3Result) {
    let total_errors = phase1.error_count + phase2.error_count + phase3.error_count;
    
    if total_errors > 0 {
        info!("✓ Scan completed: {} new files, {} reused, {} symbols, {} references ({} errors)", ...);
    } else {
        info!("✓ Scan completed: {} new files, {} reused, {} symbols, {} references", ...);
    }
}

Tests validate both paths and verify correct error aggregation across all phases.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• 192.168.1.100
  • Triggering command: /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 --test-threads=4 --emit=dep-info,metadata -C opt-level=1 -C embed-bitcode=no /src/lib.rs codegen-units=256 -C debuginfo=2 -C ttp ld/libgit2-sys-6--detach 391434208d186a.03vezhwziri9anrj51plxwh9p.1ivzc5n.rcgu.o 391434208d186a.06ri2rxu3b84aka49nyzzxhb1.1ivzc5n.rcgu.o 391434208d186a.0/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc 391434208d186a.0--crate-name 391434208d186a.0event_listener 391434208d186a.0--edition=2021 (packet block)
• invalid-host
  • Triggering command: /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 --test-threads=4 --emit=dep-info,metadata -C opt-level=1 -C embed-bitcode=no /src/lib.rs codegen-units=256 -C debuginfo=2 -C ttp ld/libgit2-sys-6--detach 391434208d186a.03vezhwziri9anrj51plxwh9p.1ivzc5n.rcgu.o 391434208d186a.06ri2rxu3b84aka49nyzzxhb1.1ivzc5n.rcgu.o 391434208d186a.0/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc 391434208d186a.0--crate-name 391434208d186a.0event_listener 391434208d186a.0--edition=2021 (dns block)
• invalid-uri
  • Triggering command: /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 --test-threads=4 --emit=dep-info,metadata -C opt-level=1 -C embed-bitcode=no /src/lib.rs codegen-units=256 -C debuginfo=2 -C ttp ld/libgit2-sys-6--detach 391434208d186a.03vezhwziri9anrj51plxwh9p.1ivzc5n.rcgu.o 391434208d186a.06ri2rxu3b84aka49nyzzxhb1.1ivzc5n.rcgu.o 391434208d186a.0/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc 391434208d186a.0--crate-name 391434208d186a.0event_listener 391434208d186a.0--edition=2021 (dns block)
• neo4j.example.com
  • Triggering command: /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 --test-threads=4 --emit=dep-info,metadata -C opt-level=1 -C embed-bitcode=no /src/lib.rs codegen-units=256 -C debuginfo=2 -C ttp ld/libgit2-sys-6--detach 391434208d186a.03vezhwziri9anrj51plxwh9p.1ivzc5n.rcgu.o 391434208d186a.06ri2rxu3b84aka49nyzzxhb1.1ivzc5n.rcgu.o 391434208d186a.0/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc 391434208d186a.0--crate-name 391434208d186a.0event_listener 391434208d186a.0--edition=2021 (dns block)
• neo4j.production.example.com
  • Triggering command: /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 --test-threads=4 --emit=dep-info,metadata -C opt-level=1 -C embed-bitcode=no /src/lib.rs codegen-units=256 -C debuginfo=2 -C ttp ld/libgit2-sys-6--detach 391434208d186a.03vezhwziri9anrj51plxwh9p.1ivzc5n.rcgu.o 391434208d186a.06ri2rxu3b84aka49nyzzxhb1.1ivzc5n.rcgu.o 391434208d186a.0/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc 391434208d186a.0--crate-name 391434208d186a.0event_listener 391434208d186a.0--edition=2021 (dns block)
• nonexistent.host.that.does.not.exist
  • Triggering command: /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 --test-threads=4 --emit=dep-info,metadata -C opt-level=1 -C embed-bitcode=no /src/lib.rs codegen-units=256 -C debuginfo=2 -C ttp ld/libgit2-sys-6--detach 391434208d186a.03vezhwziri9anrj51plxwh9p.1ivzc5n.rcgu.o 391434208d186a.06ri2rxu3b84aka49nyzzxhb1.1ivzc5n.rcgu.o 391434208d186a.0/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc 391434208d186a.0--crate-name 391434208d186a.0event_listener 391434208d186a.0--edition=2021 (dns block)
• not-a-valid-uri
  • Triggering command: /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 /home/REDACTED/work/mother/mother/target/debug/deps/mother_cli-d349731c4bc5c110 --test-threads=4 --emit=dep-info,metadata -C opt-level=1 -C embed-bitcode=no /src/lib.rs codegen-units=256 -C debuginfo=2 -C ttp ld/libgit2-sys-6--detach 391434208d186a.03vezhwziri9anrj51plxwh9p.1ivzc5n.rcgu.o 391434208d186a.06ri2rxu3b84aka49nyzzxhb1.1ivzc5n.rcgu.o 391434208d186a.0/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc 391434208d186a.0--crate-name 391434208d186a.0event_listener 391434208d186a.0--edition=2021 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Add comprehensive tests for the scan-log-scan-summary module.

Issues to Resolve

• test: Add tests for function mother::commands::scan::log_scan_summary #34: test: Add tests for function mother::commands::scan::log_scan_summary

CRITICAL REQUIREMENTS

1. TEST THROUGH PUBLIC API ONLY

• Do NOT make private methods public just for testing
• Test internal logic through public entrypoint functions
• If a function is private, test it via the public function that calls it

2. VERIFY LOGIC CORRECTNESS

• READ and UNDERSTAND the implementation before writing tests
• Check if the logic makes sense and is correct
• If you find bugs, note them but still test current behavior

3. TEST FILE LOCATION AND NAMING

• Unit tests: scan_log_scan_summary/tests/tests_*.rs (tests folder inside module)
• Integration tests: tests/scan_log_scan_summary/tests_*.rs (module folder inside root tests/)
• Use prefix tests_ for all test files (e.g., tests_selection_range.rs)
• All tests for this batch go in the appropriate folder
• Example unit test: server/selection_range.rs → server/tests/tests_selection_range.rs
• Example integration test: server/selection_range.rs → tests/server/tests_selection_range.rs

4. QUALITY TESTS ONLY

• NO TODO comments or placeholder tests
• Test edge cases: empty inputs, error conditions, boundaries
• Descriptive test names explaining what's tested

5. CLOSE ALL ISSUES IN ONE COMMIT

Commit message: test: Add comprehensive tests for scan-log-scan-summary (closes #34)

6. VERIFY BEFORE PR

• make run-guidelines must pass
• Then create PR

Create a single PR resolving all 1 issues.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.