Repository navigation
Exercise ARP parsing and loopback port scans - #50
Merged
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARP discovery previously mixed command execution and platform parsing inside a catch-all that converted missing tools, permission failures, and parse regressions into an indistinguishable empty result. Port scanning had only parameter-validation coverage.
This change separates macOS
arp, Linuxip neigh, and Linux fallbackarpparsing into a private pure function. Recognized malformed neighbor lines, missing commands, and nonzero platform-command exits now terminate with an actionable error. The obsolete PowerShell 5 branch is removed, and Windows neighbor errors use-ErrorAction Stop.Fixture tests cover macOS and both Linux formats, interface filtering, incomplete entries, dotted interface names, and malformed candidates. A mock-free loopback test starts a real
TcpListener, verifies an open and closed ephemeral port, and captures a server banner.Validation:
git diff --checkpassed. PowerShell is unavailable on the local host; GitHub Actions will run Pester on Linux, macOS, and Windows plus PSScriptAnalyzer.Closes #13