Repository navigation
Mark heuristic SNMP links as provisional - #49
Merged
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The best-effort SNMP parser marked every IPv4-looking value as verified
L2-SNMP, including arbitrary strings that merely mentioned a known address. The exporter then drew those guesses as solid green physical links.This change accepts only typed
IpAddressand four-octetHex-STRINGvalues, keeps the existing self-loop and known-node guards, and labels parser outputL2-SNMP-Heuristic. Provisional hints render as dashed amber, distinct from verified solid green and inferred dashed gray. Edge merging uses an explicit confidence order and never promotes a link based onSource = SNMPalone.Tests cover unrelated strings, valid typed addresses, hex addresses, self references, malformed octets, unknown nodes, merge behavior, and exported styling. README guidance states the confidence boundary.
Validation:
git diff --checkpassed. PowerShell is unavailable on the local host; GitHub Actions will run Pester on Linux, macOS, and Windows plus PSScriptAnalyzer.Closes #20