Skip to content

Mark heuristic SNMP links as provisional - #49

Merged
jacobyoby merged 1 commit into
mainfrom
fix/issue-20-snmp-confidence
Sep 9, 2026
Merged

jacobyoby merged 1 commit into
mainfrom
fix/issue-20-snmp-confidence

Conversation

@jacobyoby

Copy link
Copy Markdown
Owner

The best-effort SNMP parser marked every IPv4-looking value as verified L2-SNMP, including arbitrary strings that merely mentioned a known address. The exporter then drew those guesses as solid green physical links.

This change accepts only typed IpAddress and four-octet Hex-STRING values, keeps the existing self-loop and known-node guards, and labels parser output L2-SNMP-Heuristic. Provisional hints render as dashed amber, distinct from verified solid green and inferred dashed gray. Edge merging uses an explicit confidence order and never promotes a link based on Source = SNMP alone.

Tests cover unrelated strings, valid typed addresses, hex addresses, self references, malformed octets, unknown nodes, merge behavior, and exported styling. README guidance states the confidence boundary.

Validation: git diff --check passed. PowerShell is unavailable on the local host; GitHub Actions will run Pester on Linux, macOS, and Windows plus PSScriptAnalyzer.

Closes #20

@jacobyoby
jacobyoby merged commit 0cf2ca4 into main Sep 9, 2026
4 checks passed
@jacobyoby
jacobyoby deleted the fix/issue-20-snmp-confidence branch September 9, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P1: Keep heuristic SNMP links distinct from verified physical topology

1 participant