Repository navigation
Size draw.io subnet containers to their nodes - #48
Merged
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subnet containers were fixed at 800×550 while nodes continued in four-column rows. The seventeenth node already extended outside its parent, and fixed 600-pixel row spacing let larger containers overlap the row below.
This change assigns nodes to subnets before rendering, sizes each container from its child count, and starts each two-column row below the tallest container above it. Unmatched nodes begin below the actual final container boundary.
Parameterized XML tests cover 0, 1, 16, 17, and 50 nodes per subnet. A multi-subnet fixture checks pairwise non-overlap and verifies that an unmatched node is placed below every container.
Validation:
git diff --checkpassed. PowerShell is unavailable on the local host; GitHub Actions will run Pester on Linux, macOS, and Windows plus PSScriptAnalyzer. Interactive draw.io inspection remains required before merge.Closes #19