Repository navigation
Enforce the IPv4 inventory contract - #46
Merged
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import-Inventorypreviously accepted any nonempty IP or CIDR string, silently skipped malformed entries, and allowed duplicate device addresses into the topology even though downstream matching is IPv4-only.This change defines and enforces the stable IPv4 inventory contract. Device and subnet collections must be arrays; each entry receives an indexed error; IPv6, invalid octets, and invalid prefixes are rejected; device addresses must be unique; and CIDR host bits are normalized to the network address. Empty inventories remain valid. Unknown roles remain valid and map to the Access layer.
README documentation states the accepted shapes, normalization rules, IPv4 boundary, duplicate behavior, and unknown-role behavior. Seven fixture tests cover the acceptance paths without network access.
Validation:
git diff --checkpassed. PowerShell is unavailable on the local host; GitHub Actions will run Pester on Linux, macOS, and Windows plus PSScriptAnalyzer.Closes #18