Skip to content

test: smoke-test the Claude review workflow - #8

Closed
jacobyoby wants to merge 2 commits into
mainfrom
test/review-workflow-smoke
Closed

jacobyoby wants to merge 2 commits into
mainfrom
test/review-workflow-smoke

Conversation

@jacobyoby

Copy link
Copy Markdown
Contributor

Throwaway PR to confirm the review step executes now that ANTHROPIC_API_KEY is set. Will be closed without merging.

🤖 Generated with Claude Code

https://claude.ai/code/session_017RYiDstNPvrtMqDr3cEqY4

jacobyoby added a commit that referenced this pull request Sep 11, 2026
The action needs it to exchange the job's OIDC token for a Claude GitHub
App installation token. Without it the review step fails with
"Could not fetch an OIDC token" (PR #8 run 34562301648). The earlier
comment claiming the permission was unused was wrong.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RYiDstNPvrtMqDr3cEqY4
jacobyoby added a commit that referenced this pull request Sep 11, 2026
The action needs it to exchange the job's OIDC token for a Claude GitHub
App installation token. Without it the review step fails with
"Could not fetch an OIDC token" (PR #8 run 34562301648). The earlier
comment claiming the permission was unused was wrong.


Claude-Session: https://claude.ai/code/session_017RYiDstNPvrtMqDr3cEqY4

Co-authored-by: jacobyoby <jacobyoby@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
@jacobyoby
jacobyoby force-pushed the test/review-workflow-smoke branch from 76fe644 to c44dc73 Compare September 11, 2026 04:42
@claude

claude Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Claude finished @jacobyoby's task in 1m 0s —— View job


Claude Code Review

  • Gather context (diff, changed files)
  • Read docs/BRAND.md, docs/ARTWORK.md, docs/LEGAL.md
  • Review the diff against those standards
  • Post review

Verdict: no findings. The change is sound.

The entire diff is one trailing blank line at the end of SECURITY.md:

@@ -61,3 +61,4 @@
 question, and what you believe was misattributed. We publish how addresses are selected, and we correct entries that
 are wrong.
+

The file now ends wrong.\n\n instead of wrong.\n. I confirmed there is nothing else in it — git diff --ignore-blank-lines origin/main...HEAD returns empty, so this is whitespace-only.

Checked against the review standards, all clear:

Check Result
Factual drift vs. live sites / docs/LEGAL.md No prose changed. The EIN, the 501(c)(3) + 170(b)(1)(A)(vi) classification and the February 11, 2025 effective date in docs/LEGAL.md are untouched.
Overclaiming No capability or limit statements changed. The feed@jacobrakai.org routing note at SECURITY.md:59-63 still keeps its "That is not a security report" caveat.
Links No links added, removed or retargeted.
Markdown sanitizer No markup added. A blank line before EOF renders as nothing.
docs/BRAND.md No profile/*.svg touched, so the frozen mastheads and the light/dark pairs are byte-identical; no stroke weights, no numbers baked into artwork.
Accessibility No images, no headings, no alt text affected.

Two small notes, neither blocking:

  1. Trailing newline style. A file ending in two newlines is what markdownlint's MD047 ("files should end with a single newline character") flags. This repo has no .markdownlint* or .editorconfig, so nothing enforces it today and nothing will fail — but if a linter is ever added to .github/workflows/, this line is the kind of thing it catches first. Worth dropping if any of these commits were ever to land on main. Fix this →

  2. Scope matches the stated intent. The PR body says this is a throwaway to confirm the review step runs now that ANTHROPIC_API_KEY is set, and that it will be closed without merging. A whitespace-only edit to a non-artwork, non-profile file is the right choice for that — it exercises the workflow without putting any public-facing claim at risk. Of the two commits, 36235ac test: re-trigger review contributes no changes to the diff.

Smoke test result: the review step executed and read the repo successfully.
· branch test/review-workflow-smoke

Throwaway PR to confirm the review step runs with the OAuth token.
Will be closed without merging.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RYiDstNPvrtMqDr3cEqY4
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RYiDstNPvrtMqDr3cEqY4
@jacobyoby

Copy link
Copy Markdown
Contributor Author

Smoke test passed: review step ran (1m24s) and posted a full review with the OAuth token. Closing without merging.

@jacobyoby jacobyoby closed this Sep 11, 2026
@jacobyoby
jacobyoby deleted the test/review-workflow-smoke branch September 11, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant