make some data copies optional#24
Draft
behinger wants to merge 2 commits into
Draft
Conversation
Author
|
I had a brief look to understand how the tests are working; but I couldnt really figure out how to run them locally. Therefore, right now there is no unit test associated with this functionality |
Collaborator
Should just be for example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #16, I introduce a new "scale_data=True" argument, which allows to provide data already scaled to uV. This saves one copy of the data in RAM without introducing side-effects.
Further, the precision conversion is done in-place in case scale_data=True already made a copy, but not if scale_data=False because we would potentially introduce side-effects