fix(e2e): accept CONFIG_ERROR in xiaoyuzhou E2E guard#1066
Merged
Conversation
PR #1059 migrated xiaoyuzhou from SSR scraping to authenticated API. The E2E tests run without credentials, producing exit code 78 (CONFIG_ERROR). The existing `isExpectedChineseSiteRestriction` guard only caught FETCH_ERROR, PARSE_ERROR, and NOT_FOUND — not config errors from missing auth credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isExpectedChineseSiteRestrictionguard only caught FETCH_ERROR/PARSE_ERROR/NOT_FOUND — not config errorscode === 78and/code: CONFIG/pattern to the guardRoot cause
3 xiaoyuzhou E2E tests failing on main:
xiaoyuzhou podcast,xiaoyuzhou podcast-episodes,xiaoyuzhou episode— all exit 78 instead of expected 0, not caught by the restriction guard.Test plan