Refactor MagicEntryParser and address several PMD issues#92
Open
ekramHoque wants to merge 13 commits into
Open
Refactor MagicEntryParser and address several PMD issues#92ekramHoque wants to merge 13 commits into
ekramHoque wants to merge 13 commits into
Conversation
…ng directory magic files
…ess and accessors
…le-checked locking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors parts of the project to improve readability, maintainability, and overall code quality while preserving existing behavior.
Refactorings
MagicEntryParser.parseLine()by extracting helper methods with single responsibilities.ContentDatafields inMagicEntryusing private fields and accessor methods.Bug Fixes
Stringidentity (==) comparisons with.equals().File.listFiles()to prevent potentialNullPointerException.internalMagicEntriesusingvolatileand double-checked locking.IOExceptiontoErrorCallBackwhen reading directory magic files.ErrorCallBackinstead of silently ignoring them.Code Quality Improvements
Addressed several PMD-reported issues including:
ifstatements.Validation
No functional behavior was intentionally changed; the modifications focus on refactoring and code quality improvements.