Skip to content

feature: add extracgin options from z.array(z.enum([]) and z.enum([])…#113

Open
bartoszgolebiowski wants to merge 1 commit into
iway1:mainfrom
bartoszgolebiowski:issue-112
Open

feature: add extracgin options from z.array(z.enum([]) and z.enum([])…#113
bartoszgolebiowski wants to merge 1 commit into
iway1:mainfrom
bartoszgolebiowski:issue-112

Conversation

@bartoszgolebiowski

Copy link
Copy Markdown

….array() via useEnumValues hook

@vercel

vercel Bot commented May 16, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-ts-form ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 7:39pm

@scamden scamden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm! one nit mentioned


export function getEnumValues(type: RTFSupportedZodTypes) {
export function getEnumValues(type: RTFSupportedZodTypes): readonly string[] | undefined {
if (type._def.typeName === z.ZodFirstPartyTypeKind.ZodArray) return getEnumValues(type._def.type)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think type.element is preferred here

@Seanmclem

Copy link
Copy Markdown

why was this not merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants