🎨 Palette: Improve Dialog accessibility#215
Conversation
Added critical WAI-ARIA roles and attributes to the custom Dialog component to improve screen reader accessibility. Included `role="dialog"` and `aria-modal="true"` to the modal container, `aria-hidden="true"` to the backdrop, and an `aria-label` to the icon-only close button. Co-authored-by: ivanleekk <84584280+ivanleekk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Added critical ARIA attributes to the custom
Dialogcomponent infrontend/src/components/ui/Dialog.tsx.role="dialog"andaria-modal="true"to the modal container.aria-hidden="true"to the backdrop to hide it from screen readers.aria-label="Close dialog"to the icon-only close<button>.🎯 Why:
Custom modal components require specific ARIA attributes to be properly announced and interacted with by screen readers. Without these, visually impaired users may not realize a modal has opened, may get lost navigating the background content, or won't know what the icon-only close button does.
📸 Before/After:
(Visuals remain unchanged, this is an underlying HTML structure improvement)
♿ Accessibility:
This change significantly improves the accessibility of all modals across the application for users relying on assistive technologies, ensuring they comply with WAI-ARIA authoring practices for dialogs.
PR created automatically by Jules for task 11781407993200268815 started by @ivanleekk