Skip to content

🎨 Palette: [Accessibility] Improve Dialog component screen reader support#211

Open
ivanleekk wants to merge 1 commit into
devfrom
palette/improve-dialog-accessibility-7428669541806484063
Open

🎨 Palette: [Accessibility] Improve Dialog component screen reader support#211
ivanleekk wants to merge 1 commit into
devfrom
palette/improve-dialog-accessibility-7428669541806484063

Conversation

@ivanleekk

Copy link
Copy Markdown
Owner

💡 What

Improved the accessibility of the Dialog component by adding appropriate ARIA attributes for screen readers.

🎯 Why

Screen reader users need context when interacting with custom modals. Without these attributes, screen readers may read background content when a modal is open, fail to announce the container as a dialog, or misinterpret the icon-only close button.

📸 Before/After

No visual changes.

♿ Accessibility

  • Added aria-hidden="true" to the modal backdrop overlay to prevent screen readers from announcing it.
  • Added role="dialog" and aria-modal="true" to the modal container to trap focus virtually and announce the element as a dialog.
  • Added aria-label="Close" to the icon-only dismiss <button>.

PR created automatically by Jules for task 7428669541806484063 started by @ivanleekk

…port

Added aria-hidden to backdrop and role/aria-modal to the dialog container. Also added an aria-label to the close button.

Co-authored-by: ivanleekk <84584280+ivanleekk@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant