Skip to content

🎨 Palette: Improve Dialog accessibility#207

Open
ivanleekk wants to merge 1 commit into
devfrom
palette/dialog-accessibility-10017942543632674388
Open

🎨 Palette: Improve Dialog accessibility#207
ivanleekk wants to merge 1 commit into
devfrom
palette/dialog-accessibility-10017942543632674388

Conversation

@ivanleekk

Copy link
Copy Markdown
Owner

💡 What: Added missing ARIA attributes to the Dialog component (aria-hidden on backdrop, role="dialog" and aria-modal="true" on modal container, and aria-label on close button).
🎯 Why: Makes the modal dialog significantly more accessible and navigable for users relying on screen readers and assistive technologies.
📸 Before/After: Visuals remain unchanged, but screen reader experience is fixed.
♿ Accessibility: Ensures the dialog announces its role properly and that the visually hidden backdrop is ignored by assistive tech.


PR created automatically by Jules for task 10017942543632674388 started by @ivanleekk

Co-authored-by: ivanleekk <84584280+ivanleekk@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant