🎨 Palette: Improve Dialog accessibility#200
Conversation
Co-authored-by: ivanleekk <84584280+ivanleekk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added standard accessibility (a11y) attributes (
aria-hidden,role,aria-modal, andaria-label) to theDialogcomponent.🎯 Why: To make custom modals natively accessible to screen readers, ensuring the backdrop is ignored, the modal container is properly recognized, and the close button is explicitly labeled.
📸 Before/After: No visual changes.
♿ Accessibility: Added
aria-hidden="true"to the dialog backdrop. Addedrole="dialog"andaria-modal="true"to the main modal container. Addedaria-label="Close"to the icon-only close button.PR created automatically by Jules for task 15118380983164708432 started by @ivanleekk