🎨 Palette: [UX improvement] Dialog Component Accessibility#193
🎨 Palette: [UX improvement] Dialog Component Accessibility#193ivanleekk wants to merge 1 commit into
Conversation
Adds `role="dialog"`, `aria-modal="true"` to the modal container, `aria-hidden="true"` to the backdrop, and an `aria-label` to the close button to improve screen reader accessibility. Co-authored-by: ivanleekk <84584280+ivanleekk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What
Added missing WAI-ARIA attributes to the custom
Dialogcomponent infrontend/src/components/ui/Dialog.tsx.🎯 Why
Custom modal components require specific ARIA attributes so that assistive technologies (like screen readers) correctly interpret them as modal dialogs, hide the background content, and provide context for icon-only buttons (like the 'X' close button).
📸 Before/After
No visual changes.
♿ Accessibility
aria-hidden="true"to the backdrop to prevent screen readers from reading background content while the modal is open.role="dialog"andaria-modal="true"to the modal container to announce it properly.aria-label="Close dialog"to the icon-only close button so visually impaired users know its function.PR created automatically by Jules for task 9062130883612119537 started by @ivanleekk