Skip to content

libavc: prevent picture buffer deletion while in use #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anshjain04 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

libavc: prevent picture buffer deletion while in use #115

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e891dba
libavc: prevent picture buffer deletion while in use
anshjain04 Feb 26, 2025
2e63974
Merge pull request #1 from ittiam-systems/main
anshjain04 Mar 19, 2025
4d2ad4f
Merge branch 'ittiam-systems:main' into dpb_mgr_null_deref
anshjain04 Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions decoder/ih264d_dpb_mgr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,13 +1314,23 @@ WORD32 ih264d_do_mmco_buffer(dpb_commands_t *ps_dpb_cmds,
{
ps_nxtDPB = ps_next_dpb;
ps_nxtDPB->u1_lt_idx = MAX_REF_BUFS + 1;
ps_nxtDPB->u1_used_as_ref = UNUSED_FOR_REF;
ps_nxtDPB->s_top_field.u1_reference_info =
UNUSED_FOR_REF;
ps_nxtDPB->s_bot_field.u1_reference_info =
UNUSED_FOR_REF;

ps_nxtDPB->ps_pic_buf = NULL;

if(ps_nxtDPB->s_top_field.u1_reference_info == IS_LONG_TERM)
ps_nxtDPB->s_top_field.u1_reference_info =
UNUSED_FOR_REF;
if(ps_nxtDPB->s_bot_field.u1_reference_info == IS_LONG_TERM)
ps_nxtDPB->s_bot_field.u1_reference_info =
UNUSED_FOR_REF;

if(ps_nxtDPB->s_bot_field.u1_reference_info == UNUSED_FOR_REF && ps_nxtDPB->s_top_field.u1_reference_info == UNUSED_FOR_REF)
{
ps_nxtDPB->ps_pic_buf = NULL;
ps_nxtDPB->u1_used_as_ref = UNUSED_FOR_REF;
}
else
{
ps_nxtDPB->u1_used_as_ref = ps_nxtDPB->s_bot_field.u1_reference_info | ps_nxtDPB->s_top_field.u1_reference_info;
}
//Release buffer
ih264d_free_ref_pic_mv_bufs(ps_dpb_mgr->pv_codec_handle,
ps_nxtDPB->u1_buf_id);
Expand Down