Repository navigation
pipe: the lease lets the request finish, a replay of a handled request is a read, and the lease length is a setting - #25
Merged
Merged
Conversation
…t is a read, and the lease length is a setting Three follow-ups to the signature lease, named in the review of #24. A failed renewal no longer cancels the request mid-pipeline: cancelling left the sender a dropped connection and the pipeline half-run, while complete_signature already re-asks whether the lease is still the request's — it completes if so and answers 503 if not. A replay of a handled request is answered from the read connection before the write lock is taken, so a bulk replay of one capture costs reads, not writes; the storm fuse is unchanged. The lease length is HOOKRELAY_SIGNATURE_LEASE_SECONDS (120 by default, at least 10), passed through the three composes that pass the replay window. Each change has a test that fails with the old behaviour back. Ceiling: the pipe moves from 6,650 to 6,700 source lines. #24 landed at exactly 6,650 by trading two dead methods for restored reasoning; these three follow-ups add 9 lines over it. The doctrine answer is the same as the raises before it: the pipe's own door and ledger, not a judgement about an alert. Argued in scripts/assert_weight.py and stated in hookrelay/README.md, README.md, docs/evidence.md and the reproduce script; README.md also had the judge's ceiling as 3,450, which has been 3,700 since 10-26.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three follow-ups named in the review of #24, by Claude (claude-opus-5-5) at the repository owner's request.
complete_signaturealready re-asks whether the lease is still the request's. The heartbeat now logs and keeps trying; a lease still the request's completes it, a lost one answers 503.HOOKRELAY_SIGNATURE_LEASE_SECONDS, 120 by default and at least 10, renewed every third of it. The stack's knob check required it to reach a compose; it is passed through the three that pass the replay window. The quickstart does not carry it.Each change has a test that was run with the old behaviour back and failed.
Ceiling: the pipe moves from 6,650 to 6,700 source lines. #24 landed at exactly 6,650 by trading two dead methods for restored reasoning, and these follow-ups add 9 lines over it. The reason is written in
scripts/assert_weight.pyand the number is updated everywhere it is stated; the root README also had the judge's ceiling as 3,450, which has been 3,700 since 10-26.Decision note:
.agents/notes/implemented/2026-10-27-the-lease-lets-the-request-finish.md.Gate: STACK GATE GREEN locally; CI read back before merging.