Skip to content

Add Country code & fix#130

Open
reindex-ot wants to merge 4 commits intoitsvic-dev:masterfrom
reindex-ot:master
Open

Add Country code & fix#130
reindex-ot wants to merge 4 commits intoitsvic-dev:masterfrom
reindex-ot:master

Conversation

@reindex-ot
Copy link
Contributor

No description provided.

@reindex-ot reindex-ot mentioned this pull request May 15, 2025
<string name="service_gls_hungary">GLS (HU)</string>
<string name="service_hungarian_post">Hungarian Post (HU)</string>
<string name="service_nova_poshta">Nova Post (UA)</string>
<string name="service_polish_post">Polish Post (PL)</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure if this is better than translating them.
Polish Post is not the official name, it's Poczta Polska. same with Magyar Posta (Hungarian Post) or Poste Italiane (Italian Post).
maybe to reduce confusion in the future we could both put the native name (Poczta Polska) and the translated name (ポーランド郵便), alongside the countries those services operate in. but as it stands, i'm not sure if this is any better.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd like to add that, as a rule of thumb, national delivery services are translated in other languages in Parcel as well, e.g. Polish Post is Polnische Post in German, and Hungarian Post is Poczta Węgierska.

<string name="service_belpost">ベルポシュタ</string>
<string name="service_dpd_uk">DPD(イギリス)</string>
<string name="service_belpost">Belposhta (BY)</string>
<string name="service_dpd_uk">DPD (GB)</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why you changed イギリス to GB here and in other strings?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, this creates an inconsistency. there are services with untranslatable names, such as eKart or Hermes, that operate in one region only, unless we edit those in the EN locale too, in which case we'd need to go to each existing translation and add a country code to a name which already has the country in it in translated form.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this isn't even correct! DPD UK services the entire United Kingdom, not just Great Britain!

<string name="service_sameday_hu">Sameday (HU)</string>
<string name="service_sameday_ro">Sameday (RO)</string>
<string name="service_spx_th">SPX (TH)</string>
<string name="service_ukrposhta">UkrPoshta (UA)</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the service name is Ukrposhta, not UkrPoshta.

<string name="save">保存</string>
<string name="service_belpost">ベルポシュタ</string>
<string name="service_dpd_uk">DPD(イギリス)</string>
<string name="service_belpost">Belposhta (BY)</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a transliteration from the native name of the delivery service. consider using Belpost (the official English name) or the native name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants