Глухов Евгений, M3337#6
Open
AntiFrizz1 wants to merge 7 commits intoitmo2019:masterfrom
Open
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://task-5-git-fork-antifrizz1-master.itmo-yandex.now.sh |
rmbaad
requested changes
May 15, 2019
|
|
||
| import * as styles from './header.module.css'; | ||
|
|
||
| const headerMail: string = require('../../images/header-mail.svg'); |
There was a problem hiding this comment.
Кажется там будет не строка. Без указания типа на что ругается?
Author
There was a problem hiding this comment.
Не ругается, я просто подумал что то, что передается в src должно иметь тип string
| }); | ||
| }; | ||
|
|
||
| isLetterHasText = (text: string, letter: LetterType) => { |
There was a problem hiding this comment.
Одно из условий задачи — чтобы это быстро работало на большом количестве писем. Проверь хотя бы на паре-тройке сотен — браузер подвисает
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Выполнены задания 1 и 3.1
Для добавления одного письма можно нажать на кнопку "Написать".
Работает выбрать все, происходит выбор всех писем на первой странице.