Балашов Ярослав, М3335#5
Open
BreakChir wants to merge 4 commits intoitmo2019:masterfrom
Open
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://task-5-git-fork-breakchir-master.itmo-yandex.now.sh |
| ], | ||
| "dependencies": { | ||
| "@bem-react/classname": "1.5.0", | ||
| "@types/classnames": "2.2.7", |
There was a problem hiding this comment.
@types должны быть в `devDependencies
| "@types/react-dom": "16.8.4", | ||
| "@types/react-window": "1.8.0", | ||
| "@types/recompose": "0.30.6", | ||
| "classnames": "2.2.6", |
| "classnames": "2.2.6", | ||
| "react": "16.8.6", | ||
| "react-dom": "16.8.6" | ||
| "react-cookie": "3.1.2", |
There was a problem hiding this comment.
| "react": "16.8.6", | ||
| "react-dom": "16.8.6" | ||
| "react-cookie": "3.1.2", | ||
| "react-cookies": "0.1.0", |
| "devDependencies": { | ||
| "@hellroot/eslint-config": "1.8.0", | ||
| "@hellroot/stylelint-config": "1.1.0", | ||
| "bemify": "0.1.2", |
| "build": "react-scripts build", | ||
| "eject": "react-scripts eject", | ||
| "lint": "npm-run-all lint:*", | ||
| "lint:js": "eslint '**/*.{js,jsx}'", |
| "dev": "react-scripts start", | ||
| "test": "react-scripts test", | ||
| "build": "react-scripts build", | ||
| "eject": "react-scripts eject", |
| cursor: pointer; | ||
| } | ||
|
|
||
| .box:after { |
| @@ -0,0 +1,29 @@ | |||
| import React from 'react'; | |||
| import pure from 'recompose/pure'; | |||
| import cx from 'classnames'; | |||
| }; | ||
|
|
||
| render() { | ||
| console.log('MailApp'); |
There was a problem hiding this comment.
console.log надо удалять перед пушем
| constructor(props: {}) { | ||
| super(props); | ||
| this.state = { | ||
| theme: this.initTheme(), |
There was a problem hiding this comment.
Вместо глубокого прокидывания пропсов лучше воспользуйся
https://reactjs.org/docs/context.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Выбрал 2.1 и 3.1
Поиск в процессе совершенствования
Работает кодовое слово "темная тема"