This repository was archived by the owner on Jun 1, 2026. It is now read-only.
fix(i18n): fill missing translations in Japanese and Korean locale files#28
Merged
Conversation
- app/ja.ts: restored Japanese translations for provider OAuth visit prefixes
("Visit ") that had been left as a formatting space
- ui/ja.ts: filled empty lineComment label/editorLabel prefixes
("行目: ", "コメント編集中: ")
- ui/ko.ts: filled empty lineComment label/editorLabel prefixes
("라인 ", "편집 중 ")
All 652 app and 51 UI i18n parity tests pass. Lint shows 0 errors.
Co-Authored-By: codeplane-agent[bot] <287208015+codeplane-agent[bot]@users.noreply.github.com>
…docs
CLI reference:
- Add totp command (generate, uri, code subcommands with flags) to synopsis
and new dedicated section; totp was an implemented but undocumented
public subcommand.
- Add generate to synopsis and update Generated/Hidden section to
accurately describe its describe:false hidden status.
- Update metadata (title, openGraph, twitter) to list totp alongside
the other documented subcommands so SEO metadata matches the synopsis.
- completion subcommand was already documented; no structural change
there beyond the metadata alignment.
Configuration reference:
- Add disabled_providers and enabled_providers to the top-level shape
JSON example and the runtime behavior table.
- Add username, default_agent, npm, and watcher to the top-level shape
JSON example (all present in packages/codeplane/src/config/config.ts
but missing from the page's example block).
- Add a new dedicated npm section with registry/authToken example and
explanation of {secret} / {env} placeholder support.
- Add compaction.tail_turns, compaction.reserved, disabled_providers,
enabled_providers, username, and default_agent to the runtime behavior
table (all defined in config.ts, none of which were listed).
- Round out the compaction example to include the new tail_turns and
reserved keys.
Verification:
- bun --cwd site run typecheck (pass)
- bun --cwd site run build (pass)
- bun --cwd packages/app test --preload ./happydom.ts ./src (652 pass)
- bun --cwd packages/ui test (362 pass)
Co-Authored-By: codeplane-agent[bot] <287208015+codeplane-agent[bot]@users.noreply.github.com>
Collaborator
Author
Review NotesVerdict: APPROVED — ready to merge What this does
Review
No issues foundThis is a docs/i18n-only change with no runtime impact. Safe to merge. |
There was a problem hiding this comment.
Pull request overview
Fills in previously empty translation entries in three i18n files (Japanese app + UI, Korean UI) and brings the CLI and configuration reference docs back in sync with the implementation in packages/codeplane/src/cli and packages/codeplane/src/config/config.ts.
Changes:
- Restore Japanese/Korean strings for
provider.connect.oauth.*.visit.prefixandui.lineComment.*entries that were blank. - Document the
codeplane totpcommand tree (and update metadata/synopsis) in the CLI reference, plus reword the "generated/hidden commands" section. - Document previously missing top-level config keys (
disabled_providers,enabled_providers,username,default_agent,npm,watcher,compaction.tail_turns,compaction.reserved) and add annpmsection + new runtime-behavior table rows.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/app/src/i18n/ja.ts | Fills two empty OAuth visit-prefix strings with "アクセス: ". |
| packages/ui/src/i18n/ja.ts | Fills empty ui.lineComment prefix strings. |
| packages/ui/src/i18n/ko.ts | Fills empty ui.lineComment prefix strings. |
| site/app/docs/cli/page.tsx | Adds totp (and generate) to synopsis/metadata, documents totp subcommands, rewords hidden-commands paragraph. |
| site/app/docs/configuration/page.tsx | Adds missing top-level keys to shape JSON, new npm section, and new runtime-behavior table rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+45
to
46
| generate regenerate the OpenAPI spec (SDK build pipeline) | ||
| completion generate shell completion script |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fill in empty translation entries in Japanese and Korean locale files, and fix documentation gaps in the CLI reference and configuration schema docs.
Changes
i18n
packages/app/src/i18n/ja.ts: restored Japanese translations forprovider.connect.oauth.code.visit.prefixandprovider.connect.oauth.auto.visit.prefix(were " ", now "アクセス: ").packages/ui/src/i18n/ja.ts: filledui.lineComment.label.prefix( → "行目: ") andui.lineComment.editorLabel.prefix( → "コメント編集中: ").packages/ui/src/i18n/ko.ts: filledui.lineComment.label.prefix( → "라인 ") andui.lineComment.editorLabel.prefix( → "편집 중 ").Documentation
CLI reference (
site/app/docs/cli/page.tsx)totpandgenerateto synopsis;totpincluded in metadata descriptions (title, openGraph, twitter) so they match the listed commands.codeplane totpsection: documentsgenerate(--account,--issuer),uri(--secret,--account,--issuer), andcode(--secret) subcommands — all present inpackages/codeplane/src/cli/cmd/totp.tsbut previously absent from the docs.describe: falserather than "intentionally hidden from normal help".completionwas already documented; metadata now correctly coverstotpalongside it.Configuration reference (
site/app/docs/configuration/page.tsx)disabled_providers,enabled_providers,username,default_agent,npm, andwatcher, plustail_turnsandreservedinsidecompaction— all defined inpackages/codeplane/src/config/config.ts.npmsection: documentsregistryandauthTokenwith{secret:…}/{env:…}placeholder support.username,default_agent,disabled_providers,enabled_providers,compaction.tail_turns, andcompaction.reserved— all previously undocumented.small_modelwas already documented in the provider/models section.Verification
bun --cwd packages/app test test/i18n/parity.test.ts— 652 passbun test packages/ui/src/i18n/i18n.test.ts— 51 passbun --cwd site run typecheck— passbun --cwd site run build— passbun --cwd packages/app test --preload ./happydom.ts ./src— 652 pass, 0 failbun --cwd packages/ui test— 362 pass, 0 fail