Skip to content

fix for removeLayer - #57

Open
matthewberryman wants to merge 1 commit into
ismyrnow:gh-pagesfrom
AcrossTheCloud:gh-pages
Open

fix for removeLayer#57
matthewberryman wants to merge 1 commit into
ismyrnow:gh-pagesfrom
AcrossTheCloud:gh-pages

Conversation

@matthewberryman

Copy link
Copy Markdown

Isolates the fix in #46 for removeLayer() - per comments in that pull request, the fix in #50 wasn't complete and we were still seeing the removeLayer error #49 .
Have tested this and it solves the issue (thanks @ForgottenLords )

@karlitos

Copy link
Copy Markdown

Can you please merge this fix into whatever branch, so I can get it with NPM ? I just spend several hours pulling my hair out till I found the source of the bug and got finally to this PR 😭

@TravnikovDev

Copy link
Copy Markdown

OMG merge this please !

@vinayakkulkarni

Copy link
Copy Markdown

Merge this please. very basic feature that should've been present from the beginning.

@ka7eh

ka7eh commented Apr 16, 2018

Copy link
Copy Markdown

Any update on merging this changeset?

@TravnikovDev

Copy link
Copy Markdown

@ka7eh This package is dead because layers control now included in leaflet
http://leafletjs.com/reference-1.3.0.html#control-layers

@ka7eh

ka7eh commented Apr 17, 2018

Copy link
Copy Markdown

@TPABHuKOB thanks for the update.

@karlitos

Copy link
Copy Markdown

@TPABHuKOB I do not think Leaflets layer controll is a full replacement of the groupedlayercontrol. How do you do grouping - headings ? You can pass HTML in the Layers labels, but the controls - checkboxes, radios - are placed before the labels. Please see my example.

@zacharyburnett

Copy link
Copy Markdown

I can confirm from my local installation that this pull request fixes the problem with removeLayer. It is a single-line fix, and definitely should be merged into master.

@corrigancd

Copy link
Copy Markdown

Also confirmed, nice fix.

@Azbesciak

Copy link
Copy Markdown

Owner? I'm just another person who has faced this problem and solved it myself ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants