Allow read-only h5 access, define IMTYPE_RGB, explicit error on too-large Waveforms #87
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kspaceKelvin
commented
Jan 21, 2026
kspaceKelvin
commented
- Issue Opening and closing MRD file via File interface updates file modified time #78 is resolved by allowing file mode to be specified when opening an HDF5 file
- An enum for IMTYPE_RGB is added as described in https://ismrmrd.readthedocs.io/en/latest/mrd_image_data.html#data-types
- An explicit TypeError is raised if attempting to create a Waveform that exceeds the maximum size
As described in tefra/xsdata#1128
naegelejd
requested changes
Jan 27, 2026
| IMTYPE_REAL = 3 | ||
| IMTYPE_IMAG = 4 | ||
| IMTYPE_COMPLEX = 5 | ||
| IMTYPE_RGB = 6 |
Contributor
There was a problem hiding this comment.
I don't see where this is defined in the C++ implementation?
What does RGB mean for each of the possible ISMRMRD image types? i.e. How is RGB decoded from a 32-bit complex float? How many bits for each RGB channel if the image is 32-bit vs 16-bit?
|
|
||
| class Dataset(object): | ||
| def __init__(self, filename, dataset_name="dataset", create_if_needed=True): | ||
| def __init__(self, filename, dataset_name="dataset", create_if_needed=True, mode=None): |
Contributor
There was a problem hiding this comment.
We should document the valid arguments for mode: https://docs.h5py.org/en/stable/high/file.html#opening-creating-files
| channels, nsamples = data.shape | ||
|
|
||
| if nsamples > np.iinfo(np.uint16).max: | ||
| raise TypeError(f"Array has {nsamples} samples, which is greater than the maximum of {np.iinfo(np.uint16).max}") |
Contributor
There was a problem hiding this comment.
This is a ValueError not a TypeError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.