Skip to content

Adds k8 manifest for UEX publisher#58

Open
Sahil-STFC wants to merge 1 commit intomainfrom
#56-Add-K8-manifest-for-User-Exchange-Publisher
Open

Adds k8 manifest for UEX publisher#58
Sahil-STFC wants to merge 1 commit intomainfrom
#56-Add-K8-manifest-for-User-Exchange-Publisher

Conversation

@Sahil-STFC
Copy link
Collaborator

closes: #56

@Sahil-STFC Sahil-STFC requested a review from a team as a code owner February 26, 2026 14:38
- host: "*.developers.facilities.rl.ac.uk"
http: &http_rules
paths:
- path: /publish/merge(/|$)(.*)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure want this as a target rewrite?

This will essentially stop any requests apart from /publish/merge/* from ever reaching a service? Also it makes any requests to /publish/merge/ to be rewriteen to /

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any harm in blocking any requests apart from /publish/merge/* . I don't understand your second question

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So lets say the app is running and expecting the path to be <some-domain>/publish/merge/123 this ingress will match on application but the path that will arive at hte service will be /<some-domain>/123 is that what you expect?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also endpoints for checking message status at /status/summary and /status/{id} and liveness and readiness tests at /q/health/live and /q/health/ready.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So lets say the app is running and expecting the path to be <some-domain>/publish/merge/123 this ingress will match on application but the path that will arive at hte service will be /<some-domain>/123 is that what you expect?

Am I correct in understanding that if we use this path then <some-domain>/publish/merge/123 will never be called because its changed to /<some-domain>/123 and our application doesn't support this route. @vovsike

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also endpoints for checking message status at /status/summary and /status/{id} and liveness and readiness tests at /q/health/live and /q/health/ready.

I did put in the probes earlier but they errored out the pod, so I thought Ill put them later once we have the publisher publish messages on dev.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand that last comment. If the liveness/readiness tests show as failing the publisher isn't working correctly and we shouldn't be trying to publish messages with it?

Comment on lines +5 to +10
spec:
ports:
- name: debug
protocol: TCP
port: 7005
targetPort: 7005
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the debug port evev exposed? on the java side?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmbrownless do we need debug port exposed for publisher ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for remote debugging the running java correct? We certainly won't want it in production 😄 but dev; is it routinely exposed on our dev services?

It's not something I routinely use and I don't think we are or should be running our containers with java_enable_debug set, it's a performance hog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add K8 manifest for User-Exchange-Publisher

3 participants