Use the DSC base for vm_protect shenanigans#2730
Merged
saagarjha merged 1 commit intoish-app:masterfrom May 3, 2026
Merged
Conversation
On more recent versions of iOS the second call to vm_protect will fail, leaving a page of the shared cache text as PROT_READ and causing crashes later. This is to my understanding incorrect but we can just not do that to work around the bug. Filed as FB22686058.
emkey1
pushed a commit
to emkey1/ish-AOK
that referenced
this pull request
May 3, 2026
Apply the upstream iOS shared-cache vm_protect workaround from ish-app#2730. Recent iOS versions can fail the second protection change, leaving shared-cache text read-only; touching the shared cache base and not restoring execute avoids that path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On more recent versions of iOS the second call to vm_protect will fail, leaving a page of the shared cache text as PROT_READ and causing crashes later. This is to my understanding incorrect but we can just not do that to work around the bug. Filed as FB22686058.