Create standard devices for command line runs#2724
Merged
tbodt merged 2 commits intoish-app:masterfrom May 3, 2026
Merged
Conversation
tbodt
reviewed
May 1, 2026
Member
|
theoretically the correct solution is to create an implementation of devtmpfs instead of creating device nodes like this. (i don't think I knew about devtmpfs at the time) |
f4787cf to
1b79c93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create standard
/devnodes during command-line emulator startup.The iOS app startup already creates
/dev/ptmx, but the CLI path only mounteddevptsat/dev/pts. Static i386tmuxcould start and parse commands, butfailed when creating the first pane because
forkptycould not open the ptymaster:
This moves the existing standard device-node setup into shared kernel init code
and calls it from both app and CLI startup. The CLI path now gets
/dev/ptmxbefore mounting
devpts, without duplicating the app's/devsetup list.Validation
ninja -C build/dev/ptmxfrom the Alpine test filesystem, then confirmed therebuilt CLI emulator recreated it on startup.
tmuxin Alpine:tmux -Vtmux -htmux -L final-smoke -f /dev/null new-session -d /bin/true