Repository navigation
lumexia: allow http:// for a Lumexia on the local network - #169
Merged
Merged
Conversation
Lumexia runs on the warehouse network, usually over plain http, but its URL went through the same rule as WooCommerce: https:// unless the host is localhost. Saving http://192.168.x.x failed with "Use an https:// address." Lumexia's URL now has its own `LocalServiceUrl` rule: https:// anywhere, or http:// for a local-network host (a private or loopback IPv4/IPv6 address, a bare hostname, or a .local, .lan, .internal or .home.arpa name). A public host still needs https://, because the API key travels in a header. WooCommerce and carrier URLs keep the stricter rule. The new message, in en and es, says http:// works on the local network.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lumexia runs on the warehouse's local network, usually over plain http. Its URL in Settings went through the same rule as WooCommerce:
https://unless the host islocalhost. So saving an address likehttp://192.168.1.20:3000failed with "Use an https:// address."Lumexia's URL now has its own
LocalServiceUrlrule inpackages/contracts/src/settings.ts:https://for any host.http://for a local-network host:10/8,172.16/12,192.168/16,127/8,169.254/16);::1,fc00::/7,fe80::/10);http://lumexia);.local,.lan,.internalor.home.arpaname.https://, because the API key travels in a header.WooCommerce and carrier URLs keep the stricter
IntegrationUrlrule, since those services are on the internet. The new error,errors.field.urlHttpsOrLocal, says http:// works on the local network, in en and es.SPEC-lumexia.mdnotes the rule.For reviewers
lumexia.corp.example.com) still needs https.Testing
http://lumexia.example.com,http://172.32.0.1,http://8.8.8.8,http://[2001:db8::1],ftp://…). It also checks that WooCommerce still refuseshttp://192.168.1.20.tsc --noEmit, which coverse2e/) pass.