Skip to content

feat(packing): redesign pack screen cards - #159

Merged
isaacvarg merged 1 commit into
mainfrom
pack/card-redesign
Nov 5, 2026
Merged

isaacvarg merged 1 commit into
mainfrom
pack/card-redesign

Conversation

@isaacvarg

Copy link
Copy Markdown
Owner

Summary

  • Selected package is listed first with a tinted header and pencil-sparkles icon; unselected packages collapse to their header
  • Item cards: void/report moved into an ellipsis menu; "packed in" reads 1 @ [box] 1 • 1 @ [box] 2
  • Package cards: full-width header, one ellipsis menu (change box, put everything, note, report, delete), weight shown as an icon that opens for editing (estimate hidden), contents shown as product images with qty that open a remove-items dialog
  • Removed the status text block above the Done buttons; the buttons show only when the order can finish
  • Adds lucide-react

Testing

  • tsc, biome and the i18n catalog test pass
  • Updated packing, packing-journey, exceptions and exceptions-journey e2e specs; they pass on the desktop project
  • rates.spec.ts fails here on POST /shipping/providers/SHIPSTATION/enabled returning 400 in test setup, in code this PR doesn't touch

Selected package first and expanded, others collapsed to a header. Item and package
actions move into icon menus. Packed-in shows box icons, package contents show product
images (tap to remove units), a saved weight shows as an icon that opens for editing.
Drops the status block above the Done buttons.
@isaacvarg
isaacvarg merged commit 5007aa2 into main Nov 5, 2026
1 check passed
@isaacvarg
isaacvarg deleted the pack/card-redesign branch November 5, 2026 23:20
isaacvarg added a commit that referenced this pull request Nov 10, 2026
These specs had never run: Next can't load SWC in the agent sandbox.
CI showed four kinds of failure, each the same on desktop and tablet:

- settings: the Lumexia card holds the Lot rules section, so the card
  has two status lines (the URL form's "Saved." and Lot rules' "isn't
  set up yet"). The URL tests now read the URL form's own status, and
  Test connection's result has a `lumexia-test-result` test id.
- settings: the lot-rule switch was clicked as a normal element, but
  React Aria's switch input is visually hidden, so the click waited
  until the test timed out. It now uses `click({ force: true })`, as
  the carriers specs do.
- lumexia: in Spanish, "Sin vincular" is both a filter option and the
  table cell. The check now looks in the table.
- lumexia-lots: "Put everything left here" moved into the package's
  ⋯ menu in the pack card redesign (#159). The spec now opens the menu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant