Dark mode additions vol 2#2207
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2207 +/- ##
========================================
Coverage 43.54% 43.55%
========================================
Files 597 597
Lines 25216 25223 +7
Branches 7477 8381 +904
========================================
+ Hits 10980 10985 +5
+ Misses 14187 14181 -6
- Partials 49 57 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
axlewin
reviewed
Jun 15, 2026
axlewin
left a comment
Contributor
There was a problem hiding this comment.
Nice, I think this is pretty much ready to un-feature-flag 👍
A few minor outstanding issues I came across while testing:
- The (i) icon on the email verification banner isn't visible
- The contrast of the red 'Overdue' text on dashboard assignment cards is too low
- On the markbook, the colour code box for "Not attempted" still blends in with the background (I realise this isn't straightforward to fix by just editing the colour, but it looks a bit odd; maybe a border around the box like we have in light mode would work?)
Otherwise I think this is good to merge.
…dark-mode [VRT] Update baselines for improvement/even-more-dark-mode
axlewin
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining documented issues with dark mode.
If any additional dark mode failures are found during testing, we probably ought to fix them here this time – but this by no means is required to be the last set of dark mode changes.