Skip to content

Dark mode additions vol 2#2207

Merged
axlewin merged 23 commits into
mainfrom
improvement/even-more-dark-mode
Jun 16, 2026
Merged

Dark mode additions vol 2#2207
axlewin merged 23 commits into
mainfrom
improvement/even-more-dark-mode

Conversation

@jacbn

@jacbn jacbn commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Fixes the remaining documented issues with dark mode.

If any additional dark mode failures are found during testing, we probably ought to fix them here this time – but this by no means is required to be the last set of dark mode changes.

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.55%. Comparing base (7f39265) to head (c79ce2a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/app/services/constants.ts 0.00% 3 Missing ⚠️
...mponents/navigation/ResearchNotificationBanner.tsx 0.00% 1 Missing ⚠️
src/app/components/pages/GameboardBuilder.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2207    +/-   ##
========================================
  Coverage   43.54%   43.55%            
========================================
  Files         597      597            
  Lines       25216    25223     +7     
  Branches     7477     8381   +904     
========================================
+ Hits        10980    10985     +5     
+ Misses      14187    14181     -6     
- Partials       49       57     +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axlewin axlewin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think this is pretty much ready to un-feature-flag 👍

A few minor outstanding issues I came across while testing:

  • The (i) icon on the email verification banner isn't visible
  • The contrast of the red 'Overdue' text on dashboard assignment cards is too low
  • On the markbook, the colour code box for "Not attempted" still blends in with the background (I realise this isn't straightforward to fix by just editing the colour, but it looks a bit odd; maybe a border around the box like we have in light mode would work?)

Otherwise I think this is good to merge.

@axlewin axlewin merged commit 69b8665 into main Jun 16, 2026
10 checks passed
@axlewin axlewin deleted the improvement/even-more-dark-mode branch June 16, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants