Fix Ada sidebar container overflows#2201
Open
jacbn wants to merge 2 commits into
Open
Conversation
Most noticeable on a large group assignment progress table.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2201 +/- ##
==========================================
- Coverage 43.55% 43.53% -0.03%
==========================================
Files 597 597
Lines 25205 25206 +1
Branches 7467 8368 +901
==========================================
- Hits 10979 10974 -5
- Misses 14177 14183 +6
Partials 49 49 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes overflow caused by changes to the Ada sidebar container.
Before (overflows to the right):


After:
Also fixes the bad float position on the share link causing certain pages without toptext to appear too small, just by hiding it for non-content pages.
Before:


After: