cmdvel_to_ackermann confused track_width and wheel_base#18
Open
JaFeKl wants to merge 1 commit intoisaac-sim:mainfrom
Open
cmdvel_to_ackermann confused track_width and wheel_base#18JaFeKl wants to merge 1 commit intoisaac-sim:mainfrom
JaFeKl wants to merge 1 commit intoisaac-sim:mainfrom
Conversation
… to calculate steering angle
pulkitg01
reviewed
Mar 11, 2026
pulkitg01
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the fix.
pulkitg01
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi I came across the following issue where I would propose some changes:
Summary
This PR fixes the steering-angle conversion in
cmdvel_to_ackermannby usingwheel_base(axle distance) instead oftrack_width(left-right wheel separation).Why
For Ackermann/bicycle-model steering:
R = v / ωδ = atan(L / R), whereLis the wheelbaseUsing
track_widthin this formula produces incorrect steering commands.Changes
steering_angle = atan(wheel_base / turning_radius)track_widthtrack_widthparameter declarations and usages from node scripts and launch fileswheel_baseonlyImpact
track_widthis no longer accepted bycmdvel_to_ackermannwheel_basein launch/config filesValidation
track_widthreferences in thecmdvel_to_ackermannpackage