Adds CI Improvements - Stage 2#4877
Merged
myurasov-nv merged 31 commits intoisaac-sim:developfrom Mar 9, 2026
Merged
Conversation
Update ECR creds RUn on pull requests Update runner type for ECR build job to use GPU Use aws cli to log in Get AWS_ACCOUNT_ID Remove ECR login step from debug workflow Login to ECR with docker config fix Check if nvcr login is broken ECR stuf Toy task inside container Add missing package installation step in Dockerfile Add progress output to Docker build step in debug workflow If image exists in ecr and if it does, pull it from there instead of building Add cache layering Start toy dockerfile from nvcr.io/nvidian/isaac-sim:latest-develop Test Skip build if image exists, improve logging messages Replace entrypoint for toy task ECR functionality RUn nvidia-smi Extract ECR functionality to action Comments
559aed3 to
2ddadc5
Compare
Contributor
Greptile SummaryThis PR introduces a new Key changes:
Confidence Score: 4/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A([PR Trigger]) --> B[build\nDockerfile.base → ECR]
A --> C[build-curobo\nDockerfile.curobo → ECR]
B --> D[test-isaaclab-tasks\nPull from ECR → run tests]
B --> E[test-isaaclab-tasks-2\nPull from ECR → run tests]
B --> F[test-general\nPull from ECR → run tests]
C --> G[test-curobo\nPull from ECR → run tests]
D --> H[combine-results\nMerge JUnit XMLs\nPost PR comment]
E --> H
F --> H
G --> H
subgraph ECR["ECR isaaclab-ci"]
I[":cache-base\nlayer cache"]
J[":cache-curobo\nlayer cache"]
K[":isaac-lab-dev--pr-N--sha\nbuilt image"]
L[":isaac-lab-dev--pr-N--sha--curobo\nbuilt image"]
end
B <-->|cache-from/to| I
C <-->|cache-from/to| J
B -->|push image| K
C -->|push image| L
D -->|pull image| K
E -->|pull image| K
F -->|pull image| K
G -->|pull image| L
Last reviewed commit: e09aff9 |
Collaborator
|
Looks amazing!! |
kellyguo11
reviewed
Mar 9, 2026
kellyguo11
approved these changes
Mar 9, 2026
myurasov-nv
added a commit
to myurasov-nv/IsaacLab
that referenced
this pull request
Mar 9, 2026
# Description Some mo CI stuff. - ECR caching for images and layers. We not only stop building docker 4 times, but layer cache makes necessary builds faaaster! - Implemented as drop-in replacement for `build-docker` action. - CI task graph is optimized for max cache usage. - ECR images are auto-deleted in a day to save costs. - Removes redundant test results copying step from build.yaml (done in the run-tests action). - Optimizes COPY commands in dockerfiles to minimize layer cache invalidation - Synced Dockerfile.base and .curobo so they use layer cache maximally ## Type of change - New feature-ish (non-breaking change which adds functionality) - Documentation update (`.github/actions/ecr-build-push-pull/README.md`) ## Screenshots <img width="1191" height="371" alt="image" src="https://github.com/user-attachments/assets/22fef48e-b38e-4f06-b2de-faff0aa89e15" /> ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [NA] I have added tests that prove my fix is effective or that my feature works - [NA] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
matthewtrepte
pushed a commit
to matthewtrepte/IsaacLab
that referenced
this pull request
Mar 9, 2026
# Description Some mo CI stuff. - ECR caching for images and layers. We not only stop building docker 4 times, but layer cache makes necessary builds faaaster! - Implemented as drop-in replacement for `build-docker` action. - CI task graph is optimized for max cache usage. - ECR images are auto-deleted in a day to save costs. - Removes redundant test results copying step from build.yaml (done in the run-tests action). - Optimizes COPY commands in dockerfiles to minimize layer cache invalidation - Synced Dockerfile.base and .curobo so they use layer cache maximally ## Type of change - New feature-ish (non-breaking change which adds functionality) - Documentation update (`.github/actions/ecr-build-push-pull/README.md`) ## Screenshots <img width="1191" height="371" alt="image" src="https://github.com/user-attachments/assets/22fef48e-b38e-4f06-b2de-faff0aa89e15" /> ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [NA] I have added tests that prove my fix is effective or that my feature works - [NA] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some mo CI stuff.
build-dockeraction.Type of change
.github/actions/ecr-build-push-pull/README.md)Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there