Repository navigation
ci: test the Laravel backend and build the Next.js frontend - #1
Merged
Merged
Conversation
No CI existed. The backend has 40 tests written and they were never run automatically. backend: PHP 8.3, composer install, then 'php artisan test' against a real PostgreSQL service — phpunit.xml points at pgsql/workless_test, not SQLite, so the Feature tests (which use RefreshDatabase) need a live database. frontend: Node 22, npm ci, npm run build. No lint step for the frontend yet: 'npm run lint' currently reports 23 errors and 26 warnings, almost all explicit 'any'. Fixing those is its own change; a permanently red CI would just be ignored. Verified locally: php artisan test --testsuite=Unit -> 16 tests, 34 assertions, all passing. The 24 Feature tests need the Postgres service this workflow adds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No CI existed. The backend has 40 tests written and never run automatically.
backend — Laravel
phpunit.xmlpoints at pgsql / workless_test, not SQLite, and the Feature tests useRefreshDatabase— so the job spins up a realpostgres:16service with a health check.frontend — Next.js
No frontend lint yet
npm run lintcurrently reports 23 errors and 26 warnings, almost all@typescript-eslint/no-explicit-any. Wiring that in today would make the CI red on its first run, and a permanently red CI gets ignored. Cleaning up the `any``s is its own pull request.Verified locally
The 24 Feature tests fail locally only for lack of a database (
connection refused 127.0.0.1:5432); they are exactly what the Postgres service in this workflow provides.