Restore Amb bracket state when first-of exits - #19
Merged
Conversation
Co-authored-by: Ademar Gonzalez <ademar@users.noreply.github.com>
ademar
marked this pull request as ready for review
July 26, 2026 13:24
Author
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_8145d4ef-b092-4941-8afe-abc17b6f7649) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
first-ofescaped throughcall/ccbefore activeamb-bracketandamb-bracket-rangecontinuations could run theirleave!callbacks. A successful first-result search therefore left caller-owned mutable state marked.Fix
Add an internal escape-cleanup chain. Bracketed choices register their
leave!callback while their continuation is active, andfirst-ofunwinds that chain before returning its first solution.Validation
dotnet run --project IronKernel -- test lib/IronKernel.Amb/IronKernel.Amb.ikproj(20 checks passed)dotnet test IronKernel.sln -c Release(225 passed)3) with bracket state restored to0.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Low Risk
Scoped fix to IronKernel.Amb search semantics with a regression test; no auth, I/O, or host integration changes.
Overview
Fixes a bug where
first-ofreturned the first solution viacall/ccwithout running activeamb-bracket/amb-bracket-rangeleave!hooks, leaving caller mutable state inconsistent.Introduces an
escapecleanup chain (parallel tosink) andwith-bracket, which registers each bracket’s teardown while its continuation runs.first-ofroutes the first emitted solution through that chain before returning, andamb-bracket/amb-bracket-rangedelegate bracketing towith-bracketinstead of inline enter/leave aroundk.Adds a regression test that nested list/range brackets under
first-ofrestore test counter state to zero after the first result (3).Reviewed by Cursor Bugbot for commit acdb952. Bugbot is set up for automated code reviews on this repo. Configure here.