Skip to content

Reintroduce type parameter lost in the rewrite for Email::Sender.#12

Open
racke wants to merge 1 commit into
ironcamel:email-senderfrom
racke:email-sender-type
Open

Reintroduce type parameter lost in the rewrite for Email::Sender.#12
racke wants to merge 1 commit into
ironcamel:email-senderfrom
racke:email-sender-type

Conversation

@racke

@racke racke commented Jul 29, 2012

Copy link
Copy Markdown
Contributor

Proposed fix for the following GitHub issue:

#10

Regards
Racke

@racke

racke commented Jul 29, 2012

Copy link
Copy Markdown
Contributor Author

Note: MIME::Entity doesn't seem to support Format 'flowed'.

Regards
Racke

@ironcamel

Copy link
Copy Markdown
Owner

I used part of your patch to add support for html and plain text emails. I have not yet added support for type 'multi'. Take a look: 1e66a34

@ironcamel

Copy link
Copy Markdown
Owner

I added a line:

    $headers{Format} ||= 'flowed' if $headers{Type} eq 'text/plain';

I noticed that you said MIME::Entity does not support Format 'flowed'. I am assuming that MIME::Entity would just pass that header on to the client and it is the job of the client to support format flowed or not. I'm not sure how exactly to test format 'flowed', but leaving that line at least does not seem to break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants