Work toward being Cloud Native and support Docker#2
Open
maxbrunet wants to merge 9 commits into
Open
Conversation
* Add Dockerfile * Change database to PostgreSQL from SQLite * Add docker-compose.yml to the development worklow * Support configuration via environment variables
Fixes error when running `rspec` `NoMethodError: undefined method `last_comment'` See rspec/rspec-core@8e723fc
Related to change from SQLite to PostgreSQL IDs do not always start at 1, change to just match digits.
This can be used for automated tests. See https://docs.docker.com/docker-hub/builds/automated-testing/
... instead of the local directory. These volumes actually persist after doing `down`. `-v` needs to be specified to remove them.
Owner
|
Hi @maxbrunet and thank you very much for contributing! It's been a while since the last time I wrote code for this repo but it's of course open for contributions! I will check the pull request and merge it as soon as possible! Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @iridakos,
I was looking for a small and simple app to make my own demo of running an app on a Cloud provider and I chose yours.
I don't know if you accept contributions or still maintain this project, but I did some work to make this application more "Cloud native" and to support Docker:
Dockerfile:postgresql-clientis only required bywait-for-postgres.sh(feel free to rewrite it in Ruby if you want to).daemon(UID 2) instead ofrootdocker-compose.ymlfor development:upand then exit (can be restarted on demand)SDTOUTdb/schema.rbwas updated automatically)docker-compose.test.ymlto create an isolated test environment (usable with Docker Hub Autotest feature)I'm not a Ruby/Rails developer, so some changes might be raw, but I'm open to feedback.
Cheers,
Max