[water] Add design doc for elements-per-thread handling#790
Open
tyb0807 wants to merge 2 commits intoiree-org:mainfrom
Open
[water] Add design doc for elements-per-thread handling#790tyb0807 wants to merge 2 commits intoiree-org:mainfrom
tyb0807 wants to merge 2 commits intoiree-org:mainfrom
Conversation
This document analyzes how elements_per_thread (EPT) is used in wave_lang and proposes that Water use index.size instead of separate EPT attributes. TL;DR: - EPT is redundant for most ops (Read, Write, MMA, Reduce, Broadcast) since it's already encoded in index.size - Only Atomic and Scatter need special attributes (atomic_count, scatter_count) since they may process fewer elements than vector size - PropagateElementsPerThread pass can be simplified/removed Signed-off-by: tyb0807 <sontuan.vu@amd.com>
Documents what code can be simplified if PropagateElementsPerThread pass is removed and type conversion happens during lowering instead. Signed-off-by: tyb0807 <sontuan.vu@amd.com>
Contributor
|
I like the plan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This document analyzes how elements_per_thread (EPT) is used in PyWave and proposes that Water use index.size instead of separate EPT attributes.
TL;DR:
Please let me know if my understanding is not correct.