Repository navigation
SingletonPerKey disposing per request in Aspnet #256
Description
Hi,
It seems that when registering a service as SingletonPerKey, and the service implements IDisposable in aspnet core, it disposes per request, however instance is created only once.
Execution flow is as follows
- First request > initialize service (ctor) > execute > call
.Dispose() - Second request > execute > call
.Dispose()
This is what i got
scope.Configure(c =>
{
c.Export<DataClientManager>().As<IDataClientManager>().Lifestyle.SingletonPerKey((scope, context) => "global");
});
public interface IDataClientManager
{
IDataClientManager Register(object type);
}
public class DataClientManager : IDataClientManager, IDisposable
{
private readonly HashSet<object> _instances = new HashSet<object>();
public IDataClientManager Register(object type)
{
_instances.Add(type);
return this;
}
public void Dispose()
{
}
}This causes some services such as GQL to not work properly, as they will Dispose and next time round it will blow.
I expects that it only Dispose once the server shuts down in the case of singleton
Versions
- Grace 7.1.0
- Grace.AspNetCore.Hosting: 7.0.1
- NetcoreApp 2.2
I have a working sample as well if needed. Thanks!
Activity
ipjohnson commentedon Apr 8, 2020
I agree it should dispose only at when the host is disposed. Can you email me the sample and I'll take a look at tonight or tomorrow morning.
stephenlautier commentedon Apr 8, 2020
Its available here https://github.com/sketch7/dotnet.multitenancy/tree/feature/initial-imp (this branch)
Sketch7.Multitenancy.Sample.ApiInteresting points:
[-]SingletonPerKey disposing in Aspnet issue[/-][+]SingletonPerKey disposing per request in Aspnet[/+]ipjohnson commentedon Apr 10, 2020
I was able to reproduce this and I'll have some time next week to release a fix. For the next couple days you could try marking the export as externally owned
.ExternallyOwned()and it will keep it from being disposed (ever).addressing disposal issue for #256 as well as more tests
ipjohnson commentedon Apr 13, 2020
Ok I have a fix for it, essentially the wrong disposal context was being used. I've released a new pre-release let me know how it works out for you.
stephenlautier commentedon Apr 14, 2020
Can you confirm if this one only I need to update
Grace: 7.1.1-RC793?stephenlautier commentedon Apr 14, 2020
After updating to the mentioned version
7.1.1-RC793, SingletonPerKey as my usage isn't working anymore. Basically can't get the data from.GetExtraDatafrom either scope/context inorder to resolve the tenantP.S. running the same sample also breaks
changing export scope to be request based for issue #256
ipjohnson commentedon Apr 14, 2020
Ok I pushed a newer version and tested it with your repo. Usually the scope & disposal scope should be the same so that you don't get data from a child scope but in your case you actually do need the data from the child scope.
stephenlautier commentedon Apr 14, 2020
Thanks I retested it again, however its partially solved. In my example the
IDataClientManageris not being disposed but the service implementingIHeroDataCliente.g.MockHotsHeroDataClientits still being disposed as it was (and is also SingletonPerKey).Further more I retested the actual scenario (e.g. GQL) and it still happens that the Schema is being disposed
ipjohnson commentedon Apr 17, 2020
As we’ve talked about this over email and it’s resolved I’m going to close this out. If you have any other issues let me know