Repository navigation

Why does this anonymous method always return true? #138

Closed

Labels

opened

on Nov 17, 2017

Grace/src/Grace/DependencyInjection/Impl/Expressions/DynamicConstructorExpressionCreator.cs

Line 237 in fef3656

return true;

ipjohnson commented on Nov 17, 2017
ipjohnson
on Nov 17, 2017
Owner
I think it's a bug and should return false, I'll take a look this weekend at fixing it and adding a use case. Thanks for finding that.
Reacted by Seabiscuit and MCDis
ipjohnson
added
bug
on Nov 17, 2017
ipjohnson
added a commit that references this issue on Nov 19, 2017
changing to return false for issue #138
7ce54c8
greendimka commented on Jan 8, 2018
greendimka
on Jan 8, 2018
Shouldn't the #138 be closed now? :)
ipjohnson commented on Jan 8, 2018
ipjohnson
on Jan 8, 2018
Owner
Good point, I'll close it now. Thanks.
ipjohnson
closed this as completed on Jan 8, 2018
ipjohnson commented on Jan 14, 2018
ipjohnson
on Jan 14, 2018
Owner
This is released in 6.3.1
Reacted by greendimka

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests