You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@tiagorosendo it looks like the constructor for the logging implementation was changed in ASP.Net core to have multiple constructors and Grace as well as other containers are having issues as the longest constructor is being used ...
I'll take a look this weekend about updating the best matching constructor logic to unroll Func<T,TResult> a little better so it picks the correct constructor in this case.
For the moment you can probably cheat and register a Func<string,LogLevel,bool> with the container just to get you down the road till I can fix it this weekend.
Sorry about this I had tested with the DI suite test that MS provides but this behavior isn't specified in the new tests.
@tiagorosendo I've tested my changes in a test asp.net core 2.0 app everything looks good so I'm going to close this out and release a nuget package with it.
Activity
ipjohnson commentedon Aug 22, 2017
@tiagorosendo it looks like the constructor for the logging implementation was changed in ASP.Net core to have multiple constructors and Grace as well as other containers are having issues as the longest constructor is being used ...
I'll take a look this weekend about updating the best matching constructor logic to unroll
Func<T,TResult>a little better so it picks the correct constructor in this case.For the moment you can probably cheat and register a
Func<string,LogLevel,bool>with the container just to get you down the road till I can fix it this weekend.Sorry about this I had tested with the DI suite test that MS provides but this behavior isn't specified in the new tests.
improving best constructor logic for issue #111
ipjohnson commentedon Aug 24, 2017
@tiagorosendo I've tested my changes in a test asp.net core 2.0 app everything looks good so I'm going to close this out and release a nuget package with it.